[mob][photos] Fix buggy create album (#3791)

ente-io · Oct 21, 2024 · 92478ec · 92478ec
2 parents 745513f + 1a92a9e
commit 92478ec
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/mobile/lib/ui/collections/new_album_icon.dart b/mobile/lib/ui/collections/new_album_icon.dart
@@ -34,8 +34,8 @@ class NewAlbumIcon extends StatelessWidget {
           alwaysShowSuccessState: false,
           initialValue: "",
           textCapitalization: TextCapitalization.words,
+          popnavAfterSubmission: false,
           onSubmit: (String text) async {
-            // indicates user cancelled the rename request
             if (text.trim() == "") {
               return;
             }
@@ -44,17 +44,19 @@ class NewAlbumIcon extends StatelessWidget {
               final Collection c =
                   await CollectionsService.instance.createAlbum(text);
               // ignore: unawaited_futures
-              routeToPage(
+              await routeToPage(
                 context,
                 CollectionPage(CollectionWithThumbnail(c, null)),
               );
+              Navigator.of(context).pop();
             } catch (e, s) {
               Logger("CreateNewAlbumIcon")
                   .severe("Failed to rename album", e, s);
               rethrow;
             }
           },
         );
+
         if (result is Exception) {
           await showGenericErrorDialog(context: context, error: result);
         }

diff --git a/mobile/lib/ui/components/dialog_widget.dart b/mobile/lib/ui/components/dialog_widget.dart
@@ -180,6 +180,7 @@ class TextInputDialog extends StatefulWidget {
   final TextEditingController? textEditingController;
   final List<TextInputFormatter>? textInputFormatter;
   final TextInputType? textInputType;
+  final bool popnavAfterSubmission;
   const TextInputDialog({
     required this.title,
     this.body,
@@ -200,6 +201,7 @@ class TextInputDialog extends StatefulWidget {
     this.textEditingController,
     this.textInputFormatter,
     this.textInputType,
+    this.popnavAfterSubmission = true,
     super.key,
   });
 
@@ -273,7 +275,7 @@ class _TextInputDialogState extends State<TextInputDialog> {
                 maxLength: widget.maxLength,
                 submitNotifier: _submitNotifier,
                 onSubmit: widget.onSubmit,
-                popNavAfterSubmission: true,
+                popNavAfterSubmission: widget.popnavAfterSubmission,
                 showOnlyLoadingState: widget.showOnlyLoadingState,
                 textCapitalization: widget.textCapitalization,
                 alwaysShowSuccessState: widget.alwaysShowSuccessState,

diff --git a/mobile/lib/utils/dialog_util.dart b/mobile/lib/utils/dialog_util.dart
@@ -357,6 +357,7 @@ Future<dynamic> showTextInputDialog(
   List<TextInputFormatter>? textInputFormatter,
   TextInputType? textInputType,
   bool useRootNavigator = false,
+  bool popnavAfterSubmission = true,
 }) {
   return showDialog(
     barrierColor: backdropFaintDark,
@@ -388,6 +389,7 @@ Future<dynamic> showTextInputDialog(
             textEditingController: textEditingController,
             textInputFormatter: textInputFormatter,
             textInputType: textInputType,
+            popnavAfterSubmission: popnavAfterSubmission,
           ),
         ),
       );