[mob] Discover improvements (#3421)

## Description

## Tests

mobile/lib/services/machine_learning/ml_service.dart

@@ -131,6 +131,10 @@ class MLService {
         );
         await clusterAllImages();
       }
+      if (_mlControllerStatus == true) {
+        // refresh discover section
+        MagicCacheService.instance.updateCache().ignore();
+      }
       await indexAllImages();
       if ((await MLDataDB.instance.getUnclusteredFaceCount()) > 0) {
         await clusterAllImages();
@@ -208,6 +212,9 @@ class MLService {
         );
         fileAnalyzedCount += sumFutures;
       }
+      if (fileAnalyzedCount > 0) {
+        MagicCacheService.instance.queueUpdate('fileIndexed');
+      }
       _logger.info(
         "`indexAllImages()` finished. Analyzed $fileAnalyzedCount images, in ${stopwatch.elapsed.inSeconds} seconds (avg of ${stopwatch.elapsed.inSeconds / fileAnalyzedCount} seconds per image)",
       );

mobile/lib/services/magic_cache_service.dart

@@ -174,7 +174,7 @@ class MagicCacheService {
       _updateCacheIfTheTimeHasCome();
     });
     Bus.instance.on<FileUploadedEvent>().listen((event) {
-      _pendingUpdateReason.add("File uploaded");
+      queueUpdate("File uploaded");
     });
   }
 
@@ -191,19 +191,23 @@ class MagicCacheService {
 
   bool get enableDiscover => localSettings.isMLIndexingEnabled;
 
+  void queueUpdate(String reason) {
+    _pendingUpdateReason.add(reason);
+  }
+
   Future<void> _updateCacheIfTheTimeHasCome() async {
     if (!enableDiscover) {
       return;
     }
     final updatedJSONFile = await RemoteAssetsService.instance
         .getAssetIfUpdated(_kMagicPromptsDataUrl);
     if (updatedJSONFile != null) {
-      _pendingUpdateReason.add("Prompts data updated");
+      queueUpdate("Prompts data updated");
     } else if (lastMagicCacheUpdateTime <
         DateTime.now()
             .subtract(const Duration(days: 1))
             .millisecondsSinceEpoch) {
-      _pendingUpdateReason.add("Cache is old");
+      queueUpdate("Cache is old");
     }
   }
 
@@ -226,7 +230,6 @@ class MagicCacheService {
         return;
       }
       _logger.info("updating magic cache ${_pendingUpdateReason.toList()}");
-      _pendingUpdateReason.clear();
       _isUpdateInProgress = true;
       final EnteWatch? w = kDebugMode ? EnteWatch("magicCacheWatch") : null;
       w?.start();
@@ -245,6 +248,7 @@ class MagicCacheService {
       w?.log("cacheWritten");
       await _resetLastMagicCacheUpdateTime();
       w?.logAndReset('done');
+      _pendingUpdateReason.clear();
       Bus.instance.fire(MagicCacheUpdatedEvent());
     } catch (e, s) {
       _logger.info("Error updating magic cache", e, s);
@@ -376,6 +380,7 @@ class MagicCacheService {
     List<Prompt> magicPromptsData,
   ) async {
     final results = <MagicCache>[];
+    final List<int> matchCount = [];
     for (Prompt prompt in magicPromptsData) {
       final fileUploadedIDs =
           await SemanticSearchService.instance.getMatchingFileIDs(
@@ -387,7 +392,9 @@ class MagicCacheService {
           MagicCache(prompt.title, fileUploadedIDs),
         );
       }
+      matchCount.add(fileUploadedIDs.length);
     }
+    _logger.info('magic result count $matchCount');
     return results;
   }
 }

mobile/pubspec.yaml

@@ -12,7 +12,7 @@ description: ente photos application
 # Read more about iOS versioning at
 # https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
 
-version: 0.9.43+943
+version: 0.9.44+944
 publish_to: none
 
 environment: