Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added (draft) doc for mobile translations + added 2 new source string… #4040

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simondubrulle
Copy link

@simondubrulle simondubrulle commented Nov 15, 2024

This is my first contribution and I wanted to start with something 'simple'. My goal is to further contribute to the translation of Ente photos. I am trying to understand that process which is not yet entirely clear to me, especially when it comes to which files must be (or do not need to be) generated.

Description

As a first (small) step, I have:

  • created 2 new source strings ('collaboratorsSuccessfullyAdded' and 'viewersSuccessfullyAdded') that replace hardcoded text in the "add_a_participant" page.
  • Created draft of a documentation for translations on mobile app (based on the doc for web app)

Tests

Tested on my Pixel 6a

Built with :

  • Flutter 3.24.3
  • JDK 17.0.2
  • Gradle 7.2

Questions

  • I have manually updated the l10n.dart file (using existing similar strings ) but I guess it should be automatically generated from the intl_en.arb file, correct? If so, is it something anyone can do and can we add the step in the doc?
  • Should the other languages be updated as well in that commit, or will they only be updated via the Github Crowdin action ? Looking at the existing PR, it seems like they might need to be updated as well in the commit.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants