Avoid using keywords in TYPE_CHECKING blocks.
#589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a keyword is used as a member name, replace it with `pass` and a comment.
Code within `TYPE_CHECKING` blocks are not executed at runtime, so they will not result in `NameError` or `AttributeError`. However, if method names or argument names use Python reserved words, or if the statements or expressions are incorrect in Python syntax, a `SyntaxError` will be raised. The newly added tests ensure that `typeannotator` avoids such situations: - If there are method names that match Python reserved words, `typeannotator` replaces them with `pass` and comments. - If there are argument names that match Python reserved words, `typeannotator` replaces them with `*args` or `**kwargs`. - If there are methods that specify required arguments after optional arguments, `typeannotator` replaces them with `**kwargs`. It was challenging to find a "real-world" COM library that covered all these cases. Therefore, in these tests, using `typedesc`s as a test double to simulate the results of parsing a COM type library. It has been confirmed through the discussions in the following issue that the changes made to the production code in commit 35f3336 prevent errors from occurring in a real COM library. enthought#588 (comment)
junkmd
added
bug
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Jul 17, 2024
|
Thank you so much for your quick support @junkmd |
|
@junkmd I see that this fix is scheduled for the upcoming 1.4.6 release. Any idea of when this release will be published? |
|
I am planning to release As mentioned in this comment, |
That's great! Looking forward to the release :-) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #588