Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 as a runtime dependency #16

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Add base64 as a runtime dependency #16

merged 2 commits into from
Feb 22, 2024

Conversation

orien
Copy link
Member

@orien orien commented Feb 21, 2024

Context

EjsonWrapper uses the base64 library from the Ruby standard library:

In the forthcoming Ruby 3.4, the base64 library will be come a 'bundled' library. It must be included in gem sets to be used with Bundler.

In Ruby 3.3 a deprecation warning is shown:

warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

Example: https://github.com/envato/ejson_wrapper/actions/runs/7643628676/job/20826109584#step:4:6

Change

Add base64 as a runtime dependency in the gemspec.

@orien orien requested a review from viraptor February 21, 2024 05:33
@orien orien merged commit 447ec58 into main Feb 22, 2024
14 checks passed
@orien orien deleted the base64 branch February 22, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants