use non-clashing core jar name across mapmate, messagemate, httpmate #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of module-info.java and
Automatic-Module-Name
in theMANIFEST.MF
,the jar name part before the version string will determine what module name
a jar is imported as in a modularized java application.
mapmate core, httpmate core, message core all use
core-x.y.z.jar
as jar filename.So they can't be loaded in a modularized java application because their automatically
derived module name clashes.
Automatic-Module-Name
Derivation is not handled by the javadoc command correctly (as Richard reported):so the last resort is to assign a module name is to change the jar file name of the maven artifact.
As mentioned on https://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html
SO we're left with the jar file name modification to avoid clashes.
This PR fixes that for this project.
This is no guarantee that loading the modules will succeed, but at the very least, it will enable me to go one step further, and see what the next problem is, if any.