Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder proto validation error message #38089

Merged
merged 2 commits into from
Jan 21, 2025

Fix the one over-specific test

acdeeef
Select commit
Loading
Failed to load commit list.
Merged

Reorder proto validation error message #38089

Fix the one over-specific test
acdeeef
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/iOS skipped Jan 17, 2025 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/38089/main@acdeeef)

ravenblackx @ravenblackx acdeeef #38089 merge main@884691f

Reorder proto validation error message

Commit Message: Reorder proto validation error message
Additional Description: As discussed in #38064, the error message is currently often hard to interpret due to the ordering being "high-level low-level high-level" rather than the usual high-to-low ordering error messages have, leading to confusing adjacencies. This is a minimal reordering that doesn't break tests and makes the error message easier to read, for example

Proto constraint validation failed (HttpProtocolOptionsValidationError.ExplicitHttpConfig: embedded message failed validation | caused by field: "protocol_config", reason: is required): explicit_http_config

becomes

explicit_http_config: Proto constraint validation failed (HttpProtocolOptionsValidationError.ExplicitHttpConfig: embedded message failed validation | caused by field: "protocol_config", reason: is required)

Risk Level: Very low it's just an error string.
Testing: Existing tests still pass.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Environment

Request variables

Key Value
ref 26a6d8c
sha acdeeef
pr 38089
base-sha 884691f
actor ravenblackx @ravenblackx
message Reorder proto validation error message...
started 1737139251.089718
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 34
patch 0
dev true