Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Integrate aws cluster manager capability #38271

Merged
merged 32 commits into from
Feb 7, 2025

Conversation

nbaws
Copy link
Contributor

@nbaws nbaws commented Jan 30, 2025

Commit Message: aws: Integrate aws cluster manager capability
Additional Description:

Part 2 of 3 patches, to address customer reported bugs in the aws request signing extension when using the route discovery service.
This change connects extension to the aws cluster manager, then removes cluster management functionality from MetadataCredentialsProviderBase.
Statistics related to CDS removal are deprecated, as we now use avoid_cds_removal flag in clusterManager().addOrUpdateCluster(). These statistics were only used for test cases.

Part 1 - #38205

Risk Level: Low
Testing: Unit
Docs Changes: remove reference to clusters_removed_by_cds statistics

Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

nbaws and others added 16 commits January 27, 2025 04:56
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
@nbaws nbaws requested a review from mattklein123 as a code owner January 30, 2025 23:58
@nbaws nbaws marked this pull request as draft January 30, 2025 23:59
nbaws added 9 commits January 31, 2025 05:35
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
@nbaws
Copy link
Contributor Author

nbaws commented Feb 1, 2025

/retest

@nbaws nbaws marked this pull request as ready for review February 1, 2025 08:46
@adisuissa
Copy link
Contributor

Assigning @suniltheta for a first pass
/assign @suniltheta

@adisuissa
Copy link
Contributor

Assigning @mattklein123 as code-owner and maintainer.
/assign @mattklein123

nbaws and others added 6 commits February 5, 2025 08:25
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
@nbaws
Copy link
Contributor Author

nbaws commented Feb 6, 2025

/retest

@mattklein123 mattklein123 merged commit 32f2793 into envoyproxy:main Feb 7, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants