Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor-perf: move tcp listener address shared ptr #38348

Merged

Conversation

adisuissa
Copy link
Contributor

Commit Message: minor-perf: move tcp listener address shared ptr
Additional Description:
Minor-perf: moving a shared pointer instead of copying it.

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38348 was opened by adisuissa.

see: more, trace.

@adisuissa adisuissa marked this pull request as ready for review February 7, 2025 16:08
Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement.

@mattklein123 mattklein123 merged commit 6a69e4e into envoyproxy:main Feb 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants