Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor-perf: move secret provider string #38350

Merged
merged 1 commit into from
Feb 10, 2025

minor-perf: move secret provide string

e37d585
Select commit
Loading
Failed to load commit list.
Merged

minor-perf: move secret provider string #38350

minor-perf: move secret provide string
e37d585
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Publish and verify succeeded Feb 7, 2025 in 35m 10s

Envoy/Publish and verify (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/Publish and verify (pr/38350/main@e37d585)

Check started by

Request (pr/38350/main@e37d585)

adisuissa @adisuissa e37d585 #38350 merge main@1706a64

minor-perf: move secret provider string

Commit Message: minor-perf: move secret provider string
Additional Description:
Minor perf-nit: moving a secret provider string instead of copying it

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Environment

Request variables

Key Value
ref f82b345
sha e37d585
pr 38350
base-sha 1706a64
actor adisuissa @adisuissa
message minor-perf: move secret provider string...
started 1738947563.035737
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 34
patch 0
dev true