Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/listener: apply socket options on additional address #38409

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

jronak
Copy link
Contributor

@jronak jronak commented Feb 12, 2025

Commit Message: This pull request fixes an issue where socket options configured on an additional address were not applied if no socket options were specified on the primary listener address. With this change, any socket options on the additional address are now correctly applied.

Additional Description:
Reference config:

static_resources:
  listeners:
  - name: "ingress"
    address:
      socket_address:
        address: 127.0.0.1
        port_value: 1234
    additional_addresses:
    - address:
        socket_address:
          address: 127.0.0.2
          port_value: 5678
      socket_options:
        socket_options:
        - level: 1
          name: 2
          int_value: 3
          state: STATE_PREBIND
        - level: 4
          name: 5
          int_value: 6
          state: STATE_PREBIND

With this PR, the above socket options on 127.0.0.2 will be applied even though there are no socket options on 127.0.0.1.

Please let me know if this needs to go behind a runtime guard. Thanks!

Risk Level: low
Testing: unit & integration test

@mattklein123 mattklein123 merged commit ced3dcc into envoyproxy:main Feb 12, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants