Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base path test for gh-pages #5

Merged
merged 5 commits into from
Mar 11, 2024
Merged

base path test for gh-pages #5

merged 5 commits into from
Mar 11, 2024

Conversation

santilland
Copy link
Collaborator

updated eodash package, included base path on build to test deployment in ghpages path

Copy link

github-actions bot commented Mar 11, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-11 20:38 UTC

@santilland santilland requested a review from A-Behairi March 11, 2024 16:31
@santilland
Copy link
Collaborator Author

So, it seems i got the basic thing now working, it was quite complicated to find the issues of setting the base path.
It is now possible to see pull request based github pages client deployments, as can be seen in the preview action referenced above.
The problem right now is that not the correct configuration is being loaded. The default one is loaded, but i think that might have to do with the renaming of the config location to src. Could you please check @A-Behairi ?
I also added a default 404 page for the root gh-pages that copies the index.html. This should in theory allow direct path requests to still work within gh-pages, but we need to merge to main in order to test it.
Could you have a look at the wrong loading of the config and merge if you find the issue?

@A-Behairi
Copy link
Collaborator

Thanks for the updates! The config location was based on the version from eodash/eodash#5. I updated to the latest release from eodash/eodash#7.

@A-Behairi A-Behairi merged commit 3ceed13 into main Mar 11, 2024
1 check passed
@A-Behairi A-Behairi deleted the basepath branch March 19, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants