chore: review-induced renamings

epam · Jan 20, 2025 · 57eb4eb · 57eb4eb
1 parent efaaf8f
commit 57eb4eb
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/aidial_adapter_bedrock/llm/chat_emulator.py b/aidial_adapter_bedrock/llm/chat_emulator.py
@@ -29,9 +29,9 @@ class CueMapping(TypedDict):
 
 class BasicChatEmulator(ChatEmulator):
     prelude_template: Optional[str]
-    add_cue: Callable[[Message, int], bool]
-    add_invitation_cue: bool
-    fallback_to_completion: bool
+    should_prefix_with_cue: Callable[[Message, int], bool]
+    should_add_invitation_cue: bool
+    should_fallback_to_completion: bool
     cues: CueMapping
     separator: str
 
@@ -55,7 +55,7 @@ def _get_cue(self, message: Message) -> Optional[str]:
     def _format_message(self, message: Message, idx: int) -> str:
         cue = self._get_cue(message)
 
-        if cue is None or not self.add_cue(message, idx):
+        if cue is None or not self.should_prefix_with_cue(message, idx):
             cue_prefix = ""
         else:
             cue_prefix = cue + " "
@@ -69,7 +69,7 @@ def get_ai_cue(self) -> Optional[str]:
 
     def display(self, messages: List[Message]) -> Tuple[str, List[str]]:
         if (
-            self.fallback_to_completion
+            self.should_fallback_to_completion
             and len(messages) == 1
             and messages[0].role == Role.USER
         ):
@@ -83,7 +83,7 @@ def display(self, messages: List[Message]) -> Tuple[str, List[str]]:
         for message in messages:
             ret.append(self._format_message(message, len(ret)))
 
-        if self.add_invitation_cue:
+        if self.should_add_invitation_cue:
             ret.append(
                 self._format_message(
                     Message(role=Role.ASSISTANT, content=""), len(ret)
@@ -106,9 +106,9 @@ def display(self, messages: List[Message]) -> Tuple[str, List[str]]:
 Reply to the last message from the user taking into account the preceding dialog history.
 ====================
 """.strip(),
-    add_cue=lambda *_: True,
-    add_invitation_cue=True,
-    fallback_to_completion=True,
+    should_prefix_with_cue=lambda *_: True,
+    should_add_invitation_cue=True,
+    should_fallback_to_completion=True,
     cues=CueMapping(
         system="Human:",
         human="Human:",

diff --git a/aidial_adapter_bedrock/llm/model/claude/v1_v2/adapter.py b/aidial_adapter_bedrock/llm/model/claude/v1_v2/adapter.py
@@ -79,9 +79,9 @@ def add_cue(message: Message, idx: int) -> bool:
 
     return BasicChatEmulator(
         prelude_template=None,
-        add_cue=add_cue,
-        add_invitation_cue=True,
-        fallback_to_completion=False,
+        should_prefix_with_cue=add_cue,
+        should_add_invitation_cue=True,
+        should_fallback_to_completion=False,
         cues=CueMapping(
             system=anthropic.HUMAN_PROMPT.strip(),
             human=anthropic.HUMAN_PROMPT.strip(),

diff --git a/aidial_adapter_bedrock/llm/model/cohere.py b/aidial_adapter_bedrock/llm/model/cohere.py
@@ -126,9 +126,9 @@ async def response_to_stream(
 
 cohere_emulator = BasicChatEmulator(
     prelude_template=None,
-    add_cue=lambda _, idx: idx > 0,
-    add_invitation_cue=False,
-    fallback_to_completion=False,
+    should_prefix_with_cue=lambda _, idx: idx > 0,
+    should_add_invitation_cue=False,
+    should_fallback_to_completion=False,
     cues=CueMapping(
         system="User:",
         human="User:",

diff --git a/tests/unit_tests/chat_emulation/test_default_emulator.py b/tests/unit_tests/chat_emulation/test_default_emulator.py
@@ -7,9 +7,9 @@
 
 noop_emulator = BasicChatEmulator(
     prelude_template=None,
-    add_cue=lambda *_: False,
-    add_invitation_cue=False,
-    fallback_to_completion=False,
+    should_prefix_with_cue=lambda *_: False,
+    should_add_invitation_cue=False,
+    should_fallback_to_completion=False,
     cues=CueMapping(system=None, human=None, ai=None),
     separator="",
 )