fix(chat): fix error placement in select folder window (Issue #1335) (#…

…2907)
epam · Jan 9, 2025 · 654ce18 · 654ce18
1 parent a952a91
commit 654ce18
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/apps/chat-e2e/src/tests/selectUploadFolder.test.ts b/apps/chat-e2e/src/tests/selectUploadFolder.test.ts
@@ -575,7 +575,6 @@ dialTest(
     attachFilesModal,
     selectFolderModal,
     selectFolders,
-    toast,
   }) => {
     setTestIds('EPMRTC-3017', 'EPMRTC-3246');
 
@@ -607,15 +606,17 @@ dialTest(
           { isHttpMethodTriggered: false },
         );
         await expect
-          .soft(toast.getElementLocator(), ExpectedMessages.errorToastIsShown)
+          .soft(
+            await selectFolderModal.getErrorContainer(),
+            ExpectedMessages.errorToastIsShown,
+          )
           .toBeVisible();
         expect
           .soft(
-            await toast.getElementContent(),
+            await selectFolderModal.getErrorMessage(),
             ExpectedMessages.errorMessageContentIsValid,
           )
           .toBe(ExpectedConstants.nameWithDotErrorMessage);
-        await selectFolders.getEditFolderInputActions().clickCancelButton();
       },
     );
 

diff --git a/apps/chat-e2e/src/ui/selectors/chatSelectors.ts b/apps/chat-e2e/src/ui/selectors/chatSelectors.ts
@@ -102,6 +102,7 @@ export const ErrorLabelSelectors = {
   notAllowedModel: '[data-qa="not-allowed-model-error"]',
   fieldError: '.text-error',
   errorText: '[data-qa="error-text"]',
+  errorContainer: '[data-qa="error-message-container"]',
 };
 
 export const ImportExportSelectors = {

diff --git a/apps/chat-e2e/src/ui/webElements/selectFolderModal.ts b/apps/chat-e2e/src/ui/webElements/selectFolderModal.ts
@@ -104,4 +104,16 @@ export class SelectFolderModal extends BaseElement {
       await this.selectFolderButton.click();
     }
   }
+
+  public async getErrorMessage() {
+    return this.getChildElementBySelector(
+      ErrorLabelSelectors.errorText,
+    ).getElementContent();
+  }
+
+  public async getErrorContainer() {
+    return this.getChildElementBySelector(
+      ErrorLabelSelectors.errorContainer,
+    ).getElementLocator();
+  }
 }
diff --git a/apps/chat/src/components/Common/ErrorMessage.tsx b/apps/chat/src/components/Common/ErrorMessage.tsx
@@ -26,6 +26,7 @@ export const ErrorMessage = ({ error, type = MessageType.ERROR }: Props) => {
         'flex w-full gap-3 rounded border p-3',
         isErrorMessage ? 'border-error bg-error' : 'border-warning bg-warning',
       )}
+      data-qa="error-message-container"
     >
       <span
         className={classNames(

diff --git a/apps/chat/src/components/Common/SelectFolder/SelectFolderList.tsx b/apps/chat/src/components/Common/SelectFolder/SelectFolderList.tsx
@@ -92,6 +92,7 @@ export const SelectFolderList = <T extends Conversation | Prompt | DialFile>({
                               ? FeatureType.File
                               : FeatureType.Prompt
                         }
+                        skipFolderRenameValidation
                         maxDepth={MAX_CONVERSATION_AND_PROMPT_FOLDERS_DEPTH}
                         currentFolder={folder}
                         highlightedFolders={highlightedFolders}