Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4145 - implement popup versions of ketcher and routing #6403

Closed
wants to merge 24 commits into from
Closed

#4145 - implement popup versions of ketcher and routing #6403

wants to merge 24 commits into from

Conversation

tanas80
Copy link
Collaborator

@tanas80 tanas80 commented Jan 31, 2025 •
edited
Loading

How does the feature work? / How did you fix the issue?

Fix example serve adding serve.json for popup and iframe urls.

Now npm run serve:standalone executes web server 'serve', which is listening on port 4002 and serving urls:
http://localhost:4002/popup - from the patch
http://localhost:4002/iframe - found in the code
http://localhost:4002/duo - two Editor instances on the same page (two react components, not iframe).
http://localhost:4002/* - as previous

Fix #4145

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Screenshots

image
image
image
image

svvald and others added 21 commits January 9, 2025 12:02
@svvald
#6240 – Export to 3-letter sequence doesn't work (#6245)
6c83076
@svvald
#6235 – Incorrect representation of hydrogens for alias charge valenc…
336054d 
…e and radical properties in macro mode (#6249)

* #6237 – Atom properties missing on initial load in Macro mode

* #6235 – Incorrect representation of hydrogens for atom alias in Macro mode

* #6235 – Fix typo

* #6235 – Fix UI tests
@svvald
#6034 – Combine two editors in ketcher-react package in order to make…
5f61c78 
… macro switcher enabled by default (#6265)

* #6034 – Combine two editors in ketcher-react package in order to make macro switcher enabled by default

* #6034 – Add loader when switching modes, change disable prop name, adjust readme files
@svvald
#6034 – Remove unnecessary transition (#6283)
67339e8
@svvald
#6303 – Update GitHub actions version to v4 (#6305)
26d6f17
@svvald
#6298 – Update Indigo to 1.28.0-rc.2 in-browser module (#6299)
10572b3 
* #6298 – Update Indigo to 1.28.0-rc.2 in-browser module

* #6298 – Update UI tests

* #6298 – Update UI tests
@rrodionov91 @ljubica-milovic
Backmerge: #6247 - Update the help document (#6312) (#6313)
c4e7ad2 
(cherry picked from commit 3284a40)

Co-authored-by: Ljubica Milovic <[email protected]>
@svvald
#6034 – Update docs for opting out of macromolecules mode (#6321)
f042fe5
@rrodionov91 @MoustaphaCamara
#3627 - Ketcher requires unsafe-eval in order to run, which contradic…
dc299b0 
…ts content security policy best practises (#6320)

This change uses ajv-cli to pre-compile the validation schema to allow running Ketcher under restrictive CSP header.
- pre-compile schema on dev mode
- prettier ignore compiled schema
- added additional fix for dev build

---------

Co-authored-by: Mouss <[email protected]>
@svvald
Update version to 3.0.0-rc.3 (#6323)
ab9cdfa
@rrodionov91
#6291 - Super G and Super T monomers do not load from a saved RXN V30…
b92d109 
…00 file (#6292)
@rrodionov91
#6344 - Excessive scroll appears in macromolecules mode in canvas if …
eca9147 
…Ketcher is inside dialog window (#6352)

* #6344 - Excessive scroll appears in macromolecules mode in canvas if Ketcher is inside dialog window
- fixed styles for Ketcher in popup
- fixed layout for right column
- updated screenshot

* #6351 - Update indigo to 1.28.0-rc.3 in browser module
@rrodionov91
#6370 - Inconsistent zoom behavior when inserting a molecule via setM…
2a668fb 
…olecule and Paste from Clipboard/Open from File (#6373)

* #6370 - Inconsistent zoom behavior when inserting a molecule via setMolecule and Paste from Clipboard/Open from File
- added autozoom for setMolecule and addFragment in macro mode

#6375 - Ketcher renders editor twice in dev mode
- removed react strict mode from editor

- updated ketcher to 3.0.0-rc.5
@rrodionov91
#6379 - Ketcher does not respond if switch to macromolecules, close p…
2be7705 
…opup with ketcher and open again (#6380)

- clear isPolymerEditorTurnedOn on Editor destroy
@rrodionov91
- updated ketcher to 3.0.0-rc.6
32d0dab
@KristinaKasyanovskaya
#6196-Ambiguous DNA bases (N, D, H, W) wrongly converted to DNA bases…
9cb129f 
… on antisense creation (#6372)
@aproskurnov
#6106 Two sense chain to one antisense connection render (#6374)
599a441 
* fixed calcuation sense and antisense backbones

* mark antisense chain only if nucleotide

* removed unused function

* fixed shift complimentary chain even if not antisense connection

* returned back behaviour drop snake mode selection after reinitialization

* updated screenshots
@tanas80
Fix example serve adding serve.json for popup and iframe urls.
3e7f372 
Fix dependencies updating.
@tanas80
Fix example serve adding serve.json for popup and iframe urls.
47ba301 
Fix dependencies updating.
@tanas80
Fix example serve adding serve.json for popup and iframe urls.
3a500da 
Fix dependencies updating.
@tanas80
Fix example serve adding serve.json for popup and iframe urls.
b20195c 
Fix dependencies updating.
@rrodionov91 rrodionov91 linked an issue Feb 2, 2025 that may be closed by this pull request
[1 day] Implement popup versions of ketcher (and routing) #4145
Closed
3 tasks
svvald
svvald approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@svvald svvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, functionality works fine, some minor comments that might be addressed later

example/src/DuoApp.tsx Show resolved Hide resolved
packages/ketcher-react/package.json Show resolved Hide resolved
example/package.json Show resolved Hide resolved
@tanas80 tanas80 changed the base branch from release/3.0 to release/3.1 February 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svvald svvald svvald approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

Assignees

@tanas80 tanas80

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1 day] Implement popup versions of ketcher (and routing)
6 participants
@tanas80 @svvald @NataliaLoginova @rrodionov91 @KristinaKasyanovskaya @aproskurnov