Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #6084 - Backmerge system doesnt allow select ambiguous monomers from the library (#6451) #6452

Conversation

tanas80
Copy link
Collaborator

@tanas80 tanas80 commented Feb 8, 2025

How the feature works? / How did you fix the issue?

Fix SequenceMode.modifySequenceInRnaBuilder replacing a monomer for other isAmbiguous value.

Fix #6084
Fix #6085

Fix SequenceMode.modifySequenceInRnaBuilder replacing a monomer for other isAmbiguous.
Fix RnaEditorExpanded adding keyDown handle for Escape, Enter.
Fix resetRnaBuilderAfterSequenceUpdate adding turnOffEditMode;
Fix SequenceItemContextMenu consts with enum.
Fix Editor.events.selectTool, .rightClickSequence using single arguments only.
Fix npm scripts adding test:types, use in prepush.
Fix editorEvent adding typing, adding keydown event.
Fix OpenOptions interactivity visuals.
Fix snapshots for OpenOptions interactivity visuals.

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Fix SequenceMode.modifySequenceInRnaBuilder replacing a monomer for other isAmbiguous.
Fix RnaEditorExpanded adding keyDown handle for Escape, Enter.
Fix resetRnaBuilderAfterSequenceUpdate adding turnOffEditMode.
Fix SequenceItemContextMenu consts with enum.
Fix Editor.events.selectTool, .rightClickSequence using single arguments only.
Fix npm scripts adding test:types, use in prepush.
Fix editorEvent adding typing, adding keydown event.
Fix OpenOptions interactivity visuals. Fix snapshots for OpenOptions interactivity visuals.
@NataliaLoginova NataliaLoginova merged commit 38e76cf into master Feb 8, 2025
10 checks passed
@NataliaLoginova NataliaLoginova deleted the 6084-system-doesnt-allow-select-ambiguous-monomers-from-the-library-from-master branch February 8, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants