This repository has been archived by the owner on Jul 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Perform an action when the user enter a voice input #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Recognized command but illegal action - Recognized command and legal action
KurohanaJuri
requested review from
alexandrepiveteau,
matt989253,
BadrTad,
barmettlerl and
Fouad-sys
May 12, 2022 11:15
matt989253
reviewed
May 12, 2022
BadrTad
reviewed
May 12, 2022
...le/src/main/java/ch/epfl/sdp/mobile/state/game/delegating/DelegatingSpeechRecognizerState.kt
Show resolved
Hide resolved
BadrTad
suggested changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a comment about a piece of code
BadrTad
approved these changes
May 12, 2022
Code Climate has analyzed commit 28e98cb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.8% (80% is the threshold). This pull request will bring the total coverage in the repository to 97.3%. View more on Code Climate. |
alexandrepiveteau
approved these changes
May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to play the blindfold chess.
If the command is recognized, the action will be performed. We also add 3 basic errors that will be display in the snackbar :
IllegalAction
: The command is recognized but it's an illegal moveUnknownCommand
: The command cannot be parsed, the input didn't respect the expected form/structureInternalError
: Default error, this need to be more specific (Will be done in another PR Create more specific errors for speech recognizer #341)Closes #338