New social icons #683
Merged
New social icons #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xentenza
commented
Sep 29, 2023
xentenza
commented
- added TikTok
- added Mastodon
- social-color.scss in alphabetical order
- added TikTok - added Mastodon - social-color.scss in alphabetical order
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
alinekeller
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Les couleurs définies dans le fichier social-colors.scss ne sont pas appliquées sur les icônes de Mastodon et Tiktok:
Il faut ajouter les styles suivants dans le fichier atoms/social-icon/social-icon.scss (vers la ligne 90, après les styles déjà définis pour les autres icônes):
.social-icon-mastodon {
background-color: $mastodon;
}
.social-icon-tiktok {
background-color: $tiktok;
}
- corrections required by Aline; - some misspellings...
williambelle
reviewed
Oct 3, 2023
| } | ||
|
|
||
| .social-icon-tiktok { | ||
| background-color: $tiktok; |
There was a problem hiding this comment.
Le logo TikTok me semble minuscule comparé aux autres:
On pourrait augmenter la taille de 1.3 comme YouTube ?
There was a problem hiding this comment.
Ce sont les fichiers de base fournis par les TikTok Brand Guidelines. Mais bonne idée, c'est modifié dans ma nouvelle PR
- Increased TikTok logo size *1.3 - social icons by alphabetical order - TikTok and Mastodon not displayed in footer
alinekeller
approved these changes
Oct 5, 2023
williambelle
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.