Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean JS for every Atoms #699

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Clean JS for every Atoms #699

wants to merge 1 commit into from

Conversation

williambelle
Copy link
Member

  • Fix eslint warnings and errors
  • Fix deprecated jQuery API

- Fix eslint warnings and errors
- Fix deprecated jQuery API
@williambelle
Copy link
Member Author

./node_modules/.bin/eslint assets/components/atoms

elements/assets/components/atoms/drawer/drawer.js
  4:29  warning  Unexpected unnamed function  func-names

elements/assets/components/atoms/popover/popover.js
   4:5  error    Unexpected function expression                             prefer-arrow-callback
   4:5  warning  Unexpected unnamed function                                func-names
  13:1  error    Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

elements/assets/components/atoms/tag/tag-input.js
  9:13  error  Expected parentheses around arrow function argument  arrow-parens

elements/assets/components/atoms/upload/upload.js
   4:48  warning  Unexpected unnamed function                                func-names
   9:13  error    Use object destructuring                                   prefer-destructuring
  13:55  error    Expected parentheses around arrow function argument        arrow-parens
  20:1   error    Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

✖ 9 problems (6 errors, 3 warnings)
  6 errors and 0 warnings potentially fixable with the `--fix` option.

Copy link

github-actions bot commented Dec 1, 2023

Unit Test Results

    1 files      1 suites   0s ⏱️
267 tests 265 ✔️ 0 💤 0  2 🔥
267 runs  263 ✔️ 0 💤 2  2 🔥

For more details on these errors, see this check.

Results for commit f991ea2.

Copy link

github-actions bot commented Dec 1, 2023

🔎 Download the Backstop report for this pull request (link valid for 90 days):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant