Fix compiler warnings #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can lead to memory deleted twice.
Recent compilers complain about using memset on a class with non-trivial copy-assignment operator. However, this is used in the the impementation of that operator. Cast to void* to silence the warning.
dirk-zimoch
commented
Feb 6, 2025
| @@ -114,7 +114,7 @@ inline void gdd::setStatSevr(aitInt16 stat, aitInt16 sevr) | |||
| { status.s.aitStat = stat; status.s.aitSevr = sevr; } | |||
|
|
|||
| inline gdd& gdd::operator=(const gdd& v) | |||
| { memcpy(this,&v,sizeof(gdd)); return *this; } | |||
| { memcpy(static_cast<void*>(this),&v,sizeof(gdd)); return *this; } | |||
There was a problem hiding this comment.
Recent compilers complain about using memset on a class with non-trivial
copy-assignment operator. However, this is used in the the impementation
of that operator. Cast to void* to silence the warning.
dirk-zimoch
commented
Feb 6, 2025
| pdd->unreference(); | ||
| delete [] buf; |
There was a problem hiding this comment.
don't unreferenced pdd with borrowed memory buf
This can lead to double delete.
dirk-zimoch
commented
Feb 6, 2025
| @@ -24,7 +24,6 @@ | |||
| casCoreClient::casCoreClient ( caServerI & serverInternal ) : | |||
| eventSys ( *this ) | |||
| { | |||
| assert ( & serverInternal ); | |||
There was a problem hiding this comment.
Address of variable can never be NULL.
| @@ -423,7 +423,7 @@ void casDGIntfIO::sendBeaconIO ( char & msg, unsigned length, | |||
| osiSockAddrNode *pAddr = reinterpret_cast<osiSockAddrNode *>(pNode); | |||
|
|
|||
| ssize_t status = sendto(this->beaconSock, &msg, length, 0, &pAddr->addr.sa, sizeof(pAddr->addr.ia)); | |||
| if ( status != length ) { | |||
| if ( status != static_cast<ssize_t>(length) ) { | |||
There was a problem hiding this comment.
Signed/unsigned mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.