-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #649: Update snapshots to fix failing CI checks #650
Conversation
It doesn't look like this has helped. Have you made sure all your local dependencies are up to date (and in particular |
All packages are updated - there was an order in which they were failing (first Mac then Windows). So maybe this just reflects the time it needs for the CRAN servers to update? Sill confusing that it would be different on Ubuntu-3.6 and the other Ubuntu systems |
yeah maybe and you are sure you have the same version of |
Because I knew there was a new release and its a classic for breaking image-based snapshots. It sounds like we should hold this PR until tomorrow or the next day and then things should have cleared up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 21 21
Lines 1786 1786
=======================================
Hits 1567 1567
Misses 219 219 ☔ View full report in Codecov by Sentry. |
The more you know! gh actions caches info. And it is possible to delete the caches. |
Description
This PR closes #649
CI tests were failing because snapshots changed. This PR updates the relevant snapshots to fix the CI failures.
Checklist
lintr::lint_package()
to check for style issues introduced by my changes.