Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #649: Update snapshots to fix failing CI checks #650

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Feb 25, 2024

Description

This PR closes #649

CI tests were failing because snapshots changed. This PR updates the relevant snapshots to fix the CI failures.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse changed the title Issue #649: Update snapshots after testthat update Issue #649: Update snapshots to fix failing CI checks Feb 25, 2024
@seabbs
Copy link
Contributor

seabbs commented Feb 26, 2024

It doesn't look like this has helped. Have you made sure all your local dependencies are up to date (and in particular ggplot2?)

@nikosbosse
Copy link
Contributor Author

All packages are updated - there was an order in which they were failing (first Mac then Windows). So maybe this just reflects the time it needs for the CRAN servers to update? Sill confusing that it would be different on Ubuntu-3.6 and the other Ubuntu systems

@seabbs
Copy link
Contributor

seabbs commented Feb 26, 2024

yeah maybe and you are sure you have the same version of ggplot2 as these others? I assume one or other of them is not actually up to date

@nikosbosse
Copy link
Contributor Author

ok it seems to be essentially that.

my local machine has ggplot2 3.5.

some CI machines download 3.5, others download 3.4.4
image

Cran has the following:
image

How did you know it was ggplot2 that caused this?
Should we just merge this and wait for a few days until tests resolve?

@seabbs
Copy link
Contributor

seabbs commented Feb 26, 2024

Because I knew there was a new release and its a classic for breaking image-based snapshots. It sounds like we should hold this PR until tomorrow or the next day and then things should have cleared up.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (23b708e) to head (104d3bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          21       21           
  Lines        1786     1786           
=======================================
  Hits         1567     1567           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse
Copy link
Contributor Author

The more you know! gh actions caches info. And it is possible to delete the caches.

Reference

@nikosbosse nikosbosse merged commit 249447f into main Feb 27, 2024
12 checks passed
@nikosbosse nikosbosse deleted the fix-snapshots branch February 27, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI snapshot tests failing on macOS-latest
2 participants