Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to exported functions #157

Closed
Tracked by #206
jamesmbaazam opened this issue Jul 12, 2024 · 10 comments
Closed
Tracked by #206

Add examples to exported functions #157

jamesmbaazam opened this issue Jul 12, 2024 · 10 comments
Labels
documentation Improvements or additions to documentation medium Nice to have for next release public release

Comments

@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Jul 12, 2024

The key exported functions could benefit from having examples. I've noted as_latent_individual(), which tends to be called as the first step before epidist(). The latter, epidist(), also could benefit from the same suggestion.

@jamesmbaazam jamesmbaazam changed the title Consider adding an example to as_latent_individual Consider adding an examples to exported functions Jul 12, 2024
@athowes
Copy link
Collaborator

athowes commented Jul 14, 2024

I agree that we should add examples! Thanks for the suggestion, and for having a look at the package in these early stages more generally

@jamesmbaazam jamesmbaazam changed the title Consider adding an examples to exported functions Consider adding examples to exported functions Jul 15, 2024
@jamesmbaazam
Copy link
Contributor Author

It's a pleasure. It's coming along nicely.

@seabbs seabbs added the documentation Improvements or additions to documentation label Jul 15, 2024
@athowes athowes added the high Required for next release label Aug 8, 2024
@athowes athowes mentioned this issue Aug 8, 2024
18 tasks
@athowes
Copy link
Collaborator

athowes commented Sep 11, 2024

Note to self that this is a good one to work on soon.

@athowes athowes self-assigned this Oct 16, 2024
@athowes
Copy link
Collaborator

athowes commented Nov 5, 2024

The first step here is to make certain data objects available. Perhaps this could also be used to simplify things being available within tests.

@seabbs seabbs added medium Nice to have for next release and removed high Required for next release labels Nov 13, 2024
@athowes
Copy link
Collaborator

athowes commented Nov 20, 2024

@seabbs is this something we might want to consider as a part of public release?

@jamesmbaazam
Copy link
Contributor Author

You'll need to do it if submitting to CRAN. It's a requirement.

@athowes
Copy link
Collaborator

athowes commented Nov 20, 2024

Thanks @jamesmbaazam. The plan we have is an inital "public" release on GitHub / R Universe next week. (After a temporary "internal" release tomorrow.) So I think CRAN is a bit longer into the future. Nonetheless I think this is a useful feature (especially for new users to the package) and it'd be nice to have sooner rather than later.

@athowes
Copy link
Collaborator

athowes commented Nov 20, 2024

PRs welcome if it's something you might feel up for tackling as part of your work!

@seabbs seabbs changed the title Consider adding examples to exported functions Add examples to exported functions Nov 22, 2024
@seabbs
Copy link
Contributor

seabbs commented Feb 12, 2025

Mostly done in #513

@seabbs
Copy link
Contributor

seabbs commented Feb 12, 2025

Im going to close this in favour of more targetted issues at remaining gaps

@seabbs seabbs closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation medium Nice to have for next release public release
Projects
None yet
Development

No branches or pull requests

3 participants