Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop with dplyr::rowwise() rather than purrr #274

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Loop with dplyr::rowwise() rather than purrr #274

merged 1 commit into from
Jan 28, 2025

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Jan 28, 2025

Attempt at solving the purrr::lift_vd() deprecation notice.

@Bisaloo Bisaloo requested a review from ntorresd January 28, 2025 10:11
@Bisaloo Bisaloo changed the title doc: change title and package description Loop owith dplyr::rowwise() rather than purrr Jan 28, 2025
@Bisaloo Bisaloo changed the title Loop owith dplyr::rowwise() rather than purrr Loop with dplyr::rowwise() rather than purrr Jan 28, 2025
@Bisaloo Bisaloo mentioned this pull request Jan 28, 2025
Closed
ntorresd
ntorresd approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@ntorresd ntorresd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that this passes the test I designed with Hmisc::binconf result as benchmark.

@ntorresd ntorresd merged commit 94235da into remove-hmisc-test Jan 28, 2025
5 of 7 checks passed
@ntorresd ntorresd deleted the remove-hmisc-hugo branch January 28, 2025 19:03
@ntorresd ntorresd mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntorresd ntorresd ntorresd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bisaloo @ntorresd