Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamically calculate th aria role #1073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomPridham
Copy link
Contributor

partially addresses #1012
This covers the problem brought up in the initial issue. There didn't seem to be other ancestor checks in this file, so I didn't attempt to do the role=cell and role=gridcell cases in the second comment. I'm also unsure if you could actually end up with that without explicitly setting the role to those since scope will always be either row, rowgroup, col, colgroup, or auto and based on this https://html.spec.whatwg.org/multipage/tables.html#attr-th-scope it seems like it always acts as a header or some sort

Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: f5ea18a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TomPridham TomPridham force-pushed the fix/1012-th-implicit-roles branch from f5ea18a to 7ab7608 Compare February 8, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant