fix: dynamically calculate th
aria role
#1073
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #1012
This covers the problem brought up in the initial issue. There didn't seem to be other ancestor checks in this file, so I didn't attempt to do the
role=cell
androle=gridcell
cases in the second comment. I'm also unsure if you could actually end up with that without explicitly setting the role to those sincescope
will always be eitherrow
,rowgroup
,col
,colgroup
, orauto
and based on this https://html.spec.whatwg.org/multipage/tables.html#attr-th-scope it seems like it always acts as a header or some sort