Improve UX of conceallevel UI warning #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation, the warning is always shown under the following conditions:
conceallevel
is something other than1
or2
globallyconceallevel = 1 | 2
locally for markdown files, but opens Neovim with a buffer that is not markdownThis can be cumbersome if:
obsidian.setup
in a non-Obsidian repo andconceallevel
is not 1 or 2conceallevel
for markdown files only, but opens Neovim in an Obsidian repo on a non-markdown fileThis PR addresses these scenarios by:
conceallevel
onBufEnter
only for markdown filesobsidian.setup
ref #286
EDIT: add friction points, add ref to issue where warning was added