Add py 3.12 to tests #570
Merged
Add py 3.12 to tests #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently tests on Windows and MacOS are failing due to an issue sharing Client objects between processes. This looks like an upstream change, but I have opened an issue on obspy here to see if anyone else has run into this. |
|
It looks like I will need to add a way to cope with the non-pickle-ability of obspy FDSN Clients. This could probably be handled by checking whether the client is an fdsn client and if it is passing the client kwargs (note, not just the url as other things might be needed) rather than the client, then instantiating a new client in each of the processes. This is probably the better way of doing it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Python 3.12 to test suite and remove 3.8
Why was it initiated? Any relevant Issues?
Python 3.12 is being pushed out on conda-forge. We need to test this first here to make sure EQcorrscan runs correctly on 3.12.