Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FetchContent module for msgpack #1040

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gikari
Copy link
Contributor

@gikari gikari commented Dec 10, 2022

Using fetch content cmake module is less verbose,
than custom download and extract logic with setting
of additional variables.

CMake version 3.16 is in the Ubuntu 20.04 repository,
so everyone should have at least it by now.

This should address the issue in #1036

@gikari gikari force-pushed the feature/fetch-content-msgpack branch from dcdaa69 to 13e542e Compare December 18, 2022 14:20
Using fetch content cmake module is less verbose,
than custom download and extract logic with setting
of additional variables.

CMake version 3.16 is in the Ubuntu 20.04 repository,
so everyone should have at least it by now.
@gikari gikari force-pushed the feature/fetch-content-msgpack branch from 13e542e to b081ad6 Compare December 18, 2022 14:21
@carlocab
Copy link
Contributor

carlocab commented Mar 5, 2023

I think these changes will break USE_SYSTEM_MSGPACK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants