refactor: updating data sources and resources for fabric cloud router (…

…#531)

- Moved fabric_cloud_Router_read _schema to fabric_cloud_router_
data_source.go
- Moved fabric_cloud_router_schema to fabric_cloud_router_resource.go
- Moved Cloud router dependent methods from fabric_mapping_helpers.go to
fabric_cloud_router_resource.go
- Updated documentation for fabric cloud router data sources & resources

docs/data-sources/equinix_fabric_cloud_router.md

@@ -30,35 +30,31 @@ data "equinix_fabric_cloud_router" "cloud_router_data_name" {
 ### Read-Only
 
 - `account` (Set of Object) Customer account information that is associated with this Fabric Cloud Router (see [below for nested schema](#nestedatt--account))
-- `bgp_ipv4_routes_count` (Number) Access point used and maximum number of IPv4 BGP routes
-- `bgp_ipv6_routes_count` (Number) Access point used and maximum number of IPv6 BGP routes
+- `bgp_ipv4_routes_count` (Number) Number of IPv4 BGP routes in use (including non-distinct prefixes)
+- `bgp_ipv6_routes_count` (Number) Number of IPv6 BGP routes in use (including non-distinct prefixes)
 - `change_log` (Set of Object) Captures Fabric Cloud Router lifecycle change information (see [below for nested schema](#nestedatt--change_log))
-- `connections_count` (Number) Number of connections associated with this Access point
+- `connections_count` (Number) Number of connections associated with this Fabric Cloud Router instance
 - `description` (String) Customer-provided Fabric Cloud Router description
+- `distinct_ipv4_prefixes_count` (Number) Number of distinct IPv4 routes
+- `distinct_ipv6_prefixes_count` (Number) Number of distinct IPv6 routes
 - `equinix_asn` (Number) Equinix ASN
 - `href` (String) Fabric Cloud Router URI information
 - `id` (String) The ID of this resource.
 - `location` (Set of Object) Fabric Cloud Router location (see [below for nested schema](#nestedatt--location))
 - `name` (String) Fabric Cloud Router name. An alpha-numeric 24 characters string which can include only hyphens and underscores
 - `notifications` (List of Object) Preferences for notifications on Fabric Cloud Router configuration or status changes (see [below for nested schema](#nestedatt--notifications))
 - `order` (Set of Object) Order information related to this Fabric Cloud Router (see [below for nested schema](#nestedatt--order))
-- `package` (Set of Object) Fabric Cloud Router package information (see [below for nested schema](#nestedatt--package))
-- `project` (Set of Object) Project information (see [below for nested schema](#nestedatt--project))
+- `package` (Set of Object) Fabric Cloud Router Package Type (see [below for nested schema](#nestedatt--package))
+- `project` (Set of Object) Customer resource hierarchy project information.Applicable to customers onboarded to Equinix Identity and Access Management. For more information see Identity and Access Management: Projects (see [below for nested schema](#nestedatt--project))
 - `state` (String) Fabric Cloud Router overall state
-- `type` (String) Defines the Fabric Cloud Router type like XF_GATEWAY
+- `type` (String) Defines the FCR type like; XF_ROUTER
 
 <a id="nestedatt--account"></a>
 ### Nested Schema for `account`
 
 Read-Only:
 
-- `account_name` (String)
 - `account_number` (Number)
-- `global_cust_id` (String)
-- `global_org_id` (String)
-- `global_organization_name` (String)
-- `org_id` (Number)
-- `organization_name` (String)
 
 
 <a id="nestedatt--change_log"></a>
@@ -127,3 +123,4 @@ Read-Only:
 
 - `href` (String)
 - `project_id` (String)
+

docs/resources/equinix_fabric_cloud_router.md

@@ -47,31 +47,42 @@ resource "equinix_fabric_cloud_router" "new_cloud_router"{
 
 ### Required
 
+- `account` (Block Set, Min: 1, Max: 1) Customer account information that is associated with this Fabric Cloud Router (see [below for nested schema](#nestedblock--account))
 - `location` (Block Set, Min: 1, Max: 1) Fabric Cloud Router location (see [below for nested schema](#nestedblock--location))
 - `name` (String) Fabric Cloud Router name. An alpha-numeric 24 characters string which can include only hyphens and underscores
 - `notifications` (Block List, Min: 1) Preferences for notifications on Fabric Cloud Router configuration or status changes (see [below for nested schema](#nestedblock--notifications))
-- `package` (Block Set, Min: 1, Max: 1) Fabric Cloud Router location (see [below for nested schema](#nestedblock--package))
-- `type` (String) Defines the FCR type like XF_ROUTER
+- `order` (Block Set, Min: 1, Max: 1) Order information related to this Fabric Cloud Router (see [below for nested schema](#nestedblock--order))
+- `package` (Block Set, Min: 1, Max: 1) Fabric Cloud Router Package Type (see [below for nested schema](#nestedblock--package))
+- `project` (Block Set, Min: 1, Max: 1) Customer resource hierarchy project information.Applicable to customers onboarded to Equinix Identity and Access Management. For more information see Identity and Access Management: Projects (see [below for nested schema](#nestedblock--project))
+- `type` (String) Defines the FCR type like; XF_ROUTER
 
 ### Optional
 
-- `account` (Block Set, Max: 1) Customer account information that is associated with this Fabric Cloud Router (see [below for nested schema](#nestedblock--account))
 - `description` (String) Customer-provided Fabric Cloud Router description
-- `order` (Block Set, Max: 1) Order information related to this Fabric Cloud Router (see [below for nested schema](#nestedblock--order))
-- `project` (Block Set, Max: 1) Fabric Cloud Router project (see [below for nested schema](#nestedblock--project))
+- `href` (String) Fabric Cloud Router URI information
 - `timeouts` (Block, Optional) (see [below for nested schema](#nestedblock--timeouts))
+- `uuid` (String) Equinix-assigned Fabric Cloud Router identifier
 
 ### Read-Only
 
-- `bgp_ipv4_routes_count` (Number) Access point used and maximum number of IPv4 BGP routes
-- `bgp_ipv6_routes_count` (Number) Access point used and maximum number of IPv6 BGP routes
+- `bgp_ipv4_routes_count` (Number) Number of IPv4 BGP routes in use (including non-distinct prefixes)
+- `bgp_ipv6_routes_count` (Number) Number of IPv6 BGP routes in use (including non-distinct prefixes)
 - `change_log` (Set of Object) Captures Fabric Cloud Router lifecycle change information (see [below for nested schema](#nestedatt--change_log))
-- `connections_count` (Number) Number of connections associated with this Access point
+- `connections_count` (Number) Number of connections associated with this Fabric Cloud Router instance
+- `distinct_ipv4_prefixes_count` (Number) Number of distinct IPv4 routes
+- `distinct_ipv6_prefixes_count` (Number) Number of distinct IPv6 routes
 - `equinix_asn` (Number) Equinix ASN
-- `href` (String) Fabric Cloud Router URI information
 - `id` (String) The ID of this resource.
 - `state` (String) Fabric Cloud Router overall state
 
+<a id="nestedblock--account"></a>
+### Nested Schema for `account`
+
+Optional:
+
+- `account_number` (Number) Account Number
+
+
 <a id="nestedblock--location"></a>
 ### Nested Schema for `location`
 
@@ -96,22 +107,6 @@ Optional:
 - `send_interval` (String) Send interval
 
 
-<a id="nestedblock--package"></a>
-### Nested Schema for `package`
-
-Required:
-
-- `code` (String) Fabric Cloud Router package code
-
-
-<a id="nestedblock--account"></a>
-### Nested Schema for `account`
-
-Optional:
-
-- `account_number` (Number) Account Number
-
-
 <a id="nestedblock--order"></a>
 ### Nested Schema for `order`
 
@@ -123,6 +118,14 @@ Optional:
 - `purchase_order_number` (String) Purchase order number
 
 
+<a id="nestedblock--package"></a>
+### Nested Schema for `package`
+
+Required:
+
+- `code` (String) Fabric Cloud Router package code
+
+
 <a id="nestedblock--project"></a>
 ### Nested Schema for `project`
 

equinix/data_source_fabric_cloud_router.go

@@ -7,16 +7,34 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
-func dataSourceCloudRouter() *schema.Resource {
+func readFabricCloudRouterResourceSchema() map[string]*schema.Schema {
+	sch := fabricCloudRouterResourceSchema()
+	for key, _ := range sch {
+		if key == "uuid" {
+			sch[key].Required = true
+			sch[key].Optional = false
+			sch[key].Computed = false
+		} else {
+			sch[key].Required = false
+			sch[key].Optional = false
+			sch[key].Computed = true
+			sch[key].MaxItems = 0
+			sch[key].ValidateFunc = nil
+		}
+	}
+	return sch
+}
+
+func dataSourceFabricCloudRouter() *schema.Resource {
 	return &schema.Resource{
-		ReadContext: dataSourceCloudRouterRead,
-		Schema:      readCloudRouterResourceSchema(),
+		ReadContext: dataSourceFabricCloudRouterRead,
+		Schema:      readFabricCloudRouterResourceSchema(),
 		Description: "Fabric V4 API compatible data resource that allow user to fetch Fabric Cloud Router for a given UUID",
 	}
 }
 
-func dataSourceCloudRouterRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func dataSourceFabricCloudRouterRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	uuid, _ := d.Get("uuid").(string)
 	d.SetId(uuid)
-	return resourceCloudRouterRead(ctx, d, meta)
+	return resourceFabricCloudRouterRead(ctx, d, meta)
 }