Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add acceptance tests for fabric connection resource/data_source and update port data_source tests #547

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

thogarty
Copy link
Contributor

  • Added acceptance tests for fabric connection resource and data_source
  • Updated attribute checks for fabric port acceptance tests
  • Updated GHA to leverage ENV variables for newly added secrets for dedicated port data and connection test data

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a60c71f) 44.71% compared to head (a724c52) 52.29%.
Report is 8 commits behind head on main.

Files Patch % Lines
internal/resources/metal/metal_connection/speed.go 81.25% 3 Missing ⚠️
equinix/resource_fabric_routing_protocol.go 0.00% 2 Missing ⚠️
equinix/resource_network_device.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   44.71%   52.29%   +7.57%     
==========================================
  Files          98       99       +1     
  Lines       19888    19890       +2     
==========================================
+ Hits         8893    10401    +1508     
+ Misses      10961     9340    -1621     
- Partials       34      149     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thogarty
Copy link
Contributor Author

thogarty commented Jan 31, 2024

Tests actually are passing. The PR is stating that it's using the up-to-date workflow file, but the test is failing because the ENV variables for secrets data aren't accessible. When running workflow manually on this target branch (which uses this branch's workflow file correctly) the tests succeed: https://github.com/equinix/terraform-provider-equinix/actions/runs/7733690362

PR is ready for merge.

srushti-patl
srushti-patl previously approved these changes Jan 31, 2024
Copy link
Contributor

@srushti-patl srushti-patl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thogarty thogarty requested a deployment to internal January 31, 2024 23:28 — with GitHub Actions Abandoned
@thogarty thogarty requested a deployment to internal January 31, 2024 23:33 — with GitHub Actions Abandoned
Copy link
Contributor

@srushti-patl srushti-patl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thogarty thogarty merged commit 7a691ea into main Jan 31, 2024
10 of 13 checks passed
@thogarty thogarty deleted the CXF-83384-connection-acceptance-tests branch January 31, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants