-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add acceptance tests for fabric connection resource/data_source and update port data_source tests #547
Conversation
thogarty
commented
Jan 31, 2024
- Added acceptance tests for fabric connection resource and data_source
- Updated attribute checks for fabric port acceptance tests
- Updated GHA to leverage ENV variables for newly added secrets for dedicated port data and connection test data
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 44.71% 52.29% +7.57%
==========================================
Files 98 99 +1
Lines 19888 19890 +2
==========================================
+ Hits 8893 10401 +1508
+ Misses 10961 9340 -1621
- Partials 34 149 +115 ☔ View full report in Codecov by Sentry. |
09f0cab
to
8642f77
Compare
Tests actually are passing. The PR is stating that it's using the up-to-date workflow file, but the test is failing because the ENV variables for secrets data aren't accessible. When running workflow manually on this target branch (which uses this branch's workflow file correctly) the tests succeed: https://github.com/equinix/terraform-provider-equinix/actions/runs/7733690362 PR is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!