-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy 2.0 #437
Merged
Merged
Numpy 2.0 #437
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for acc71ec - Browse repository at this point
Copy the full SHA acc71ecView commit details -
Migrate to v4 in download/upload artifact
From v4 artifacts must have unique names or we get "Conflict: an artifact with this name already exists on the workflow run".
Configuration menu - View commit details
-
Copy full SHA for c0f1caa - Browse repository at this point
Copy the full SHA c0f1caaView commit details -
It's been more than a year since Python 3.7 EOL.
Configuration menu - View commit details
-
Copy full SHA for b209476 - Browse repository at this point
Copy the full SHA b209476View commit details -
Looks like we are not affected by changes in numpy.
Configuration menu - View commit details
-
Copy full SHA for 8642698 - Browse repository at this point
Copy the full SHA 8642698View commit details -
macOS 11 support has been dropped. Updating to macos-13 as latest standard image that is Intel MacOS. Changing macos-13-xlarge to macos-14 as it is arm [1] and doesn't require xlarge runner. [1] https://github.com/actions/runner-images?tab=readme-ov-file#available-images
Configuration menu - View commit details
-
Copy full SHA for cea3efe - Browse repository at this point
Copy the full SHA cea3efeView commit details -
Configuration menu - View commit details
-
Copy full SHA for fed74d3 - Browse repository at this point
Copy the full SHA fed74d3View commit details
Commits on Jul 29, 2024
-
Remove reference to setuptools.command.test.test
Originally skbuild supplied its own test command which called "develop" before calling original setuptools test command. In order to avoid calling "develop", we directly exchanged this skbuild.test command with setuptools.command.test.test Note that in setup.py we only imported setuptools, not its submodules like setuptools.command.test. In skbuild they supply own version of test command to invoke and there they imported setuptools.command.test. So we happened to use this import indirectly. In 0.18 release skbuild removed custom test command in [1]. As setuptools.command.test import went along with it, we started getting errors like module 'setuptools.command' has no attribute 'test' Our use of setuptools.command.test.test might be remnant of the past though. By defining pytest as an alias of test and running python setup.py test, we shouldn't have been running setuptools test at all. Also, setuptools test seems to use unittest internally, which we don't do. As test command is removed in setuptools 72.0.0 and reason for our own override in setup.py is gone, we just drop the line altogether. [1]scikit-build/scikit-build@dde5e79
Configuration menu - View commit details
-
Copy full SHA for 05bfef5 - Browse repository at this point
Copy the full SHA 05bfef5View commit details
Commits on Aug 8, 2024
-
Wheel is still build, even though it can't be tested. Looks like wheel indication we used in cibuildwheel doesn't match the real wheel. Original intent was not to build such wheels.
Configuration menu - View commit details
-
Copy full SHA for 877c8d5 - Browse repository at this point
Copy the full SHA 877c8d5View commit details -
This is not the same as other workflows: - core.yaml builds with python turned off - wheels.yaml builds cpp core separately and then builds wheels - docs.yaml uses python build system, but no tests - bigendian.yaml is the one also doing tests, but it is slow and runs on some oldish dependencies So additional workflow is the best option to test python build.
Configuration menu - View commit details
-
Copy full SHA for 62eaddb - Browse repository at this point
Copy the full SHA 62eaddbView commit details -
Using setup.py to run commands is deprecated. Currently remove test command only as it is explicitly deprecated. pytest-runner was used to run pytests through setuptools, but now it is no longer needed.
Configuration menu - View commit details
-
Copy full SHA for c5b76a1 - Browse repository at this point
Copy the full SHA c5b76a1View commit details -
Temporary skip wheels for python 3.13
Python is in pre-release version, cibuildwheel already included it in the matrix, but not all dependencies are yet in place (looks like numpy wheels are not yet released for python 3.13).
Configuration menu - View commit details
-
Copy full SHA for 007d5e1 - Browse repository at this point
Copy the full SHA 007d5e1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.