Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 #437

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Numpy 2.0 #437

merged 11 commits into from
Aug 8, 2024

Commits on Jul 26, 2024

  1. Update versions of github actions

    Current ones are deprecated now.
    achaikou committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    acc71ec View commit details
    Browse the repository at this point in the history
  2. Migrate to v4 in download/upload artifact

    From v4 artifacts must have unique names or we get "Conflict: an
    artifact with this name already exists on the workflow run".
    achaikou committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c0f1caa View commit details
    Browse the repository at this point in the history
  3. Drop support for python 3.7

    It's been more than a year since Python 3.7 EOL.
    achaikou committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b209476 View commit details
    Browse the repository at this point in the history
  4. Unpin numpy version

    Looks like we are not affected by changes in numpy.
    achaikou committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8642698 View commit details
    Browse the repository at this point in the history
  5. Update macos github runners

    macOS 11 support has been dropped.
    Updating to macos-13 as latest standard image that is Intel MacOS.
    Changing macos-13-xlarge to macos-14 as it is arm [1] and doesn't
    require xlarge runner.
    
    [1]
    https://github.com/actions/runner-images?tab=readme-ov-file#available-images
    achaikou committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    cea3efe View commit details
    Browse the repository at this point in the history
  6. Add note about i686

    achaikou committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fed74d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Remove reference to setuptools.command.test.test

    Originally skbuild supplied its own test command which called "develop"
    before calling original setuptools test command.
    
    In order to avoid calling "develop", we directly exchanged this
    skbuild.test command with setuptools.command.test.test
    
    Note that in setup.py we only imported setuptools, not its submodules
    like setuptools.command.test.
    In skbuild they supply own version of test command to invoke and there
    they imported setuptools.command.test. So we happened to use this import
    indirectly.
    
    In 0.18 release skbuild removed custom test command in [1].
    As setuptools.command.test import went along with it, we started
    getting errors like
    module 'setuptools.command' has no attribute 'test'
    
    Our use of setuptools.command.test.test might be remnant of the past
    though.
    By defining pytest as an alias of test and running python setup.py test,
    we shouldn't have been running setuptools test at all. Also, setuptools
    test seems to use unittest internally, which we don't do.
    
    As test command is removed in setuptools 72.0.0 and reason for our own
    override in setup.py is gone, we just drop the line altogether.
    
    [1]scikit-build/scikit-build@dde5e79
    achaikou committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    05bfef5 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Fix macos 3.8 wheel skip

    Wheel is still build, even though it can't be tested. Looks like wheel
    indication we used in cibuildwheel doesn't match the real wheel.
    
    Original intent was not to build such wheels.
    achaikou committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    877c8d5 View commit details
    Browse the repository at this point in the history
  2. Add python CI build

    This is not the same as other workflows:
    - core.yaml builds with python turned off
    - wheels.yaml builds cpp core separately and then builds wheels
    - docs.yaml uses python build system, but no tests
    - bigendian.yaml is the one also doing tests, but it is slow and runs on
    some oldish dependencies
    
    So additional workflow is the best option to test python build.
    achaikou committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    62eaddb View commit details
    Browse the repository at this point in the history
  3. Drop setup.py test command

    Using setup.py to run commands is deprecated.
    Currently remove test command only as it is explicitly deprecated.
    
    pytest-runner was used to run pytests through setuptools, but now it is
    no longer needed.
    achaikou committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c5b76a1 View commit details
    Browse the repository at this point in the history
  4. Temporary skip wheels for python 3.13

    Python is in pre-release version, cibuildwheel already included it in
    the matrix, but not all dependencies are yet in place (looks like numpy
    wheels are not yet released for python 3.13).
    achaikou committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    007d5e1 View commit details
    Browse the repository at this point in the history