Avoid changing to sub_job directory for certain log files #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing any log file with $JOB_INDEX to look in the sub_job's $RUN_DIR when they lived in the parent directory.
|
This breaks our assumptions with custom_logs. It was attempting to read them from the base directory instead of the sub_job RUN_DIR. |
|
@araglu What's your plan with this PR? Is it ready to merge or did you want to come back to it? |
I need to come back to it. I think I eventually want this code change, but I still need to track down and change our use of custom_logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing any log file with $JOB_INDEX to look in the sub_job's $RUN_DIR when the log file actually lived in the parent directory. This prevented access to PBS stdout and stderr logs. If something needs to download log files from a sub_job, it can still reference $RUN_DIR for it.
CHW 600