Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

pylintrc added #645

Closed
wants to merge 9 commits into from
Closed

pylintrc added #645

wants to merge 9 commits into from

Conversation

evelynmitchell
Copy link

Doing some lint cleanup. This repository has a different naming style than pylint prefers, so I've turned that check off.

@evelynmitchell
Copy link
Author

There are quite a few functions with missing docstrings. If it is a good idea to add them, I'll do them all at once. Until then, the check is disabled.

@evelynmitchell
Copy link
Author

Turned off the check for too-many-arguments in function calls. This would be invasive to fix, and would need good test coverage to refactor.

@evelynmitchell
Copy link
Author

Turned off the check for too-many-statements in functions. This would be invasive to fix, and would need good test coverage to refactor.

@evelynmitchell
Copy link
Author

Turned off the check for too-many-branches in functions. This would be invasive to fix, and would need good test coverage to refactor.

@evelynmitchell
Copy link
Author

Turned off the check for too-many-local variables. This would be invasive to fix, and would need good test coverage to refactor.

@evelynmitchell
Copy link
Author

Turned off the check for unused-arguments. This would be a simple fix, but I would like to have good test coverage to refactor.

@erdewit
Copy link
Owner

erdewit commented Sep 21, 2023

Thanks for the PR. Currently the project uses mypy and flake8 for static code analysis (as well as PyCharm when coding) and that gives a good balance between finding actual bugs and being inundated by pedantic warnings. IMHO, the latter is what pylint does and I will pass on using and maintaining that as a linter. Of course I'd be happy if you report any bugs that pylint can find.

@erdewit erdewit closed this Sep 21, 2023
@evelynmitchell
Copy link
Author

The big set of patches which I will do in chunks, are related to logging-fstring-interpolation, which will speed up logging.

@erdewit
Copy link
Owner

erdewit commented Sep 27, 2023

I rather like the way it is right now though, with f-strings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants