Merge pull request #27 from erdnaxeli/fixes/dns

fix(sponsorblock): Catch DNS issue

CHANGELOG.md

@@ -0,0 +1,9 @@
+# v0
+
+## v0.1.1
+
+* do not crash on issue with DNS [#20](https://github.com/erdnaxeli/castblock/issues/20)
+
+## v0.1.0
+
+Initial version, the changelog was not maintained yet :)

shard.yml

@@ -1,5 +1,5 @@
 name: castblock
-version: 0.1.0
+version: 0.1.1
 
 authors:
   - Alexandre Morignot <[email protected]>
@@ -17,6 +17,6 @@ development_dependencies:
   ameba:
     github: crystal-ameba/ameba
 
-crystal: 1.0.0
+crystal: ">= 1.0.0, < 1.2"
 
 license: MIT

src/blocker.cr

@@ -74,7 +74,12 @@ class Castblock::Blocker
   private def handle_media(device : Chromecast::Device, media : Chromecast::Media) : Nil
     Log.debug &.emit("Youtube video playing", id: media.media.content_id, current_time: media.current_time)
 
-    segments = @sponsorblock.get_segments(media.media.content_id)
+    begin
+      segments = @sponsorblock.get_segments(media.media.content_id)
+    rescue Sponsorblock::Error
+      return
+    end
+
     if segments.nil?
       Log.debug &.emit("Unknown video", id: media.media.content_id)
       return

src/sponsorblock.cr

@@ -2,7 +2,10 @@ require "http"
 require "uri"
 
 class Castblock::Sponsorblock
-  class CategoryError < Exception
+  class Error < Exception
+  end
+
+  class CategoryError < Error
   end
 
   Log = Castblock::Log.for(self)
@@ -61,7 +64,12 @@ class Castblock::Sponsorblock
   end
 
   private def get(path : String, retries = 3) : HTTP::Client::Response
-    response = @client.get(path)
+    begin
+      response = @client.get(path)
+    rescue ex : Socket::Addrinfo::Error
+      Log.warn &.emit("DNS error", error: ex.to_s)
+      raise Error.new(cause: ex)
+    end
 
     if response.status.server_error?
       3.times do