Fix position when node is dragged ("sticky") #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare custom update for PR to original repository
|
Awsome contribution! It took me a while but I will try to merge it! |
|
I merged it but the threshold is unfortunately broken now. Can you remember what you have changed that would cause this to not work? |
|
That's odd, it works fine for me. It might have something to do with the other recently merged PRs. I will take a look at it this weekend and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a node's position when it is dragged, like requested in #18 and also discussed in #10 .
I did this by updating d3 from version 3 to version 4 and changing to code accordingly.
Now the graphs behave as in this example.