Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure implementors know which parse functions to use #48

Open
DanielOaks opened this issue Mar 3, 2021 · 0 comments
Open

Make sure implementors know which parse functions to use #48

DanielOaks opened this issue Mar 3, 2021 · 0 comments

Comments

@DanielOaks
Copy link
Member

Generally, servers should perform all the nice accurate proper length checking and apply appropriate restrictions. Generally, clients (unless they need to for tech reasons like memory usage or using a language that requires strict limits) should accept whatever they can from the server and not try to be too pedantic about lengths (if there's some extra body or whatever to it then it's better to read it and not throw out valid data).

  • ParseLine's comment should say "IRC clients should generally parse incoming lines using this function".
  • ParseLineStrict's comment should say "IRC servers should generally parse incoming lines using this function".

These lines should be near the top so an implementor scrolling through sees at a glance which one they should look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant