Fix issue with simplistic source models that return value-label-pairs instead of the expected array structure #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of the expected array structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Magento 2 modules (e.g.
Magento_CatalogPermissions) use source models that do not return the expected array structure containing a'label'and'value'key, but instead return a simplified array where the options value is used as key and the options label is used as value.Expected structure
[ ['value' => 0, 'label' => 'No'], ['value' => 1, 'label' => 'Yes'], ['value' => 2, 'label' => 'Maybe'], ]Simplified:
[ 0 => 'No', 1 => 'Yes', 2 => 'Maybe', ]This pull request fixes this issue.