Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename interfaces Go packages with a "proto" suffix #10142

Merged
merged 1 commit into from
May 2, 2024

Conversation

battlmonstr
Copy link
Contributor

@battlmonstr battlmonstr commented Apr 30, 2024

This depends on erigontech/interfaces#216

What's changed:

  • added "proto" suffix to packages and generated folders (I've tried to keep folder names unchanged, but it was problematic for tooling)
  • in the erigon code update package import paths, but keep them aliased to previous names such that it doesn't lead to massive code churn. We can do the code changes separately in subsequent PRs. Each code owner will do it for them.
  • had to update make grpc command: tried various --go_opt=paths=xxx (see https://protobuf.dev/reference/go/go-generated/ ), but it still generated wrong namespaces, so had to list each of them separately

@battlmonstr
Copy link
Contributor Author

battlmonstr commented Apr 30, 2024

@AskAlexSharov Thanks for review. Do you have an open PR that makes erigon compatible with erigontech/interfaces#213 ? Could you tag me on it so that I follow it up when it is merged?

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented May 1, 2024

@AskAlexSharov Thanks for review. Do you have an open PR that makes erigon compatible with ledgerwatch/interfaces#213 ? Could you tag me on it so that I follow it up when it is merged?

Giulio reverted this PR: erigontech/interfaces#214 - we just didn't merge

@battlmonstr battlmonstr force-pushed the pr/interfaces_pkg branch from 555682c to 5f4440a Compare May 2, 2024 09:40
@battlmonstr battlmonstr marked this pull request as ready for review May 2, 2024 09:41
@battlmonstr battlmonstr force-pushed the pr/interfaces_pkg branch from 5f4440a to e7c878a Compare May 2, 2024 10:40
@battlmonstr battlmonstr enabled auto-merge (squash) May 2, 2024 10:41
@battlmonstr battlmonstr merged commit 6682ecf into main May 2, 2024
10 checks passed
@battlmonstr battlmonstr deleted the pr/interfaces_pkg branch May 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants