polygon: Apply RoTx limit #11963
Merged
polygon: Apply RoTx limit #11963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
approved these changes
Sep 12, 2024
antonis19
requested changes
Sep 12, 2024
| if err != nil { | ||
| return nil, nil, nil, nil, nil, nil, nil, ff, nil, nil, err | ||
| } | ||
|
|
||
| heimdallReader, err = heimdall.AssembleReader(ctx, cc.Bor.CalculateSprintNumber, cfg.DataDir, cfg.Dirs.Tmp, logger) | ||
| heimdallReader, err = heimdall.AssembleReader(ctx, cc.Bor.CalculateSprintNumber, cfg.DataDir, cfg.Dirs.Tmp, logger, roTxLimit) |
There was a problem hiding this comment.
Would it be possible to combine cfg.DataDir, cfg.Dirs.Tmp, logger and roTxLimit to a DBConfig struct to avoid adding yet another parameter?
There was a problem hiding this comment.
yes, I agree with Elton, I actually raised the same thing in a previous PR - #11924 (comment)
There was a problem hiding this comment.
I even suggest we have separate config structs per component like
heimdall.ReaderConfigandbridge.ReaderConfigheimdall.ServiceConfigandbridge.ServiceConfig- etc.
There was a problem hiding this comment.
to keep this productive though, maybe this PR can be merged and these improvements can be done in a follow up?
There was a problem hiding this comment.
ok, I'm approving and leaving it up to Shoham.
antonis19
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11899