Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore execution-spec-tests submodule and revert PR #12925 #12976

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Restore execution-spec-tests submodule and revert PR #12925 #12976

merged 3 commits into from
Dec 3, 2024

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Dec 3, 2024 •
edited
Loading

Submodule execution-spec-tests was inadvertently deleted by PR #10915 and then PR #12925 broke the tests, which went unnoticed because of the submodule deletion.

@yperbasis yperbasis enabled auto-merge (squash) December 3, 2024 10:44
@yperbasis yperbasis disabled auto-merge December 3, 2024 10:51
@yperbasis yperbasis marked this pull request as draft December 3, 2024 11:15
@yperbasis
Copy link
Member Author

@mholt-dv It looks like PR #12926 broke TestExecutionSpec. For example:

    --- FAIL: TestExecutionSpec/prague/eip7702_set_code_tx/gas/account_warming.json (0.04s)
        --- FAIL: TestExecutionSpec/prague/eip7702_set_code_tx/gas/account_warming.json/tests/prague/eip7702__account_first_True]_28 (0.40s)
            exec_spec_test.go:41: block #1 insertion into chain failed: insertion failed for block 1, code: BadBlock
        --- FAIL: TestExecutionSpec/prague/eip7702_set_code_tx/gas/account_warming.json/tests/prague/eip7702_account_first_False]_27 (0.28s)
            exec_spec_test.go:41: block #1 insertion into chain failed: insertion failed for block 1, code: BadBlock

@yperbasis yperbasis requested a review from mh0lt December 3, 2024 11:54
@yperbasis yperbasis changed the title Restore execution-spec-tests submodule Restore execution-spec-tests submodule and revert PR #12925 Dec 3, 2024
@yperbasis yperbasis marked this pull request as ready for review December 3, 2024 11:57
@yperbasis yperbasis enabled auto-merge (squash) December 3, 2024 11:59
@yperbasis yperbasis merged commit 172fba9 into main Dec 3, 2024
30 checks passed
@yperbasis yperbasis deleted the restore-execution-spec-tests branch December 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somnathb1 somnathb1 somnathb1 approved these changes

@shohamc1 shohamc1 Awaiting requested review from shohamc1

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov

@racytech racytech Awaiting requested review from racytech

@mh0lt mh0lt Awaiting requested review from mh0lt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yperbasis @somnathb1