Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make secondsPerSlot available in chain config #13467

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Make secondsPerSlot available in chain config #13467

merged 2 commits into from
Jan 17, 2025

Conversation

yperbasis
Copy link
Member

Follow-up to PR #13426

@yperbasis yperbasis added the pectra The Prague/Electra protocol upgrade label Jan 16, 2025
@yperbasis yperbasis changed the title Make secondsPerSlot available in EL config Make secondsPerSlot available in chain config Jan 16, 2025
@yperbasis yperbasis enabled auto-merge (squash) January 16, 2025 16:09
@somnathb1
Copy link
Contributor

Genesis config and import cmd should be updated
This being non-standard, test chains and tests may be broken.
It may add dev time to launch on devnet-5. Please consider delaying merging this

@somnathb1 somnathb1 disabled auto-merge January 16, 2025 16:17
@yperbasis yperbasis marked this pull request as draft January 16, 2025 16:22
@yperbasis yperbasis marked this pull request as ready for review January 16, 2025 16:37
@yperbasis
Copy link
Member Author

Genesis config and import cmd should be updated This being non-standard, test chains and tests may be broken. It may add dev time to launch on devnet-5. Please consider delaying merging this

Good point. I've reworked this PR so that secondsPerSlot is deduced rather than set in JSON.

@yperbasis yperbasis merged commit 7b17a34 into main Jan 17, 2025
24 checks passed
@yperbasis yperbasis deleted the current_fees branch January 17, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somnathb1 somnathb1 somnathb1 approved these changes

@taratorio taratorio Awaiting requested review from taratorio

Assignees
No one assigned
Labels
pectra The Prague/Electra protocol upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yperbasis @somnathb1