Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Exposing Engine_GetPayloadV1 #227

Merged
merged 47 commits into from
Feb 12, 2022
Merged

Exposing Engine_GetPayloadV1 #227

merged 47 commits into from
Feb 12, 2022

Conversation

Giulio2002
Copy link
Contributor

No description provided.

@Giulio2002 Giulio2002 marked this pull request as draft January 29, 2022 00:09
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #227 (a3eae74) into master (182df6c) will increase coverage by 0.00%.
The diff coverage is 93.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   83.24%   83.24%           
=======================================
  Files          84       87    +3     
  Lines        4147     4160   +13     
=======================================
+ Hits         3452     3463   +11     
- Misses        695      697    +2     
Impacted Files Coverage Δ
silkrpc/commands/net_api.hpp 0.00% <ø> (ø)
silkrpc/commands/rpc_api.hpp 0.00% <0.00%> (ø)
silkrpc/commands/engine_api.cpp 80.00% <80.00%> (ø)
silkrpc/commands/engine_api.hpp 100.00% <100.00%> (ø)
silkrpc/context_pool.cpp 100.00% <100.00%> (ø)
silkrpc/ethbackend/backend.hpp 100.00% <100.00%> (ø)
silkrpc/ethbackend/backend_grpc.cpp 98.31% <100.00%> (ø)
silkrpc/ethbackend/backend_grpc.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182df6c...a3eae74. Read the comment docs.

@Giulio2002 Giulio2002 marked this pull request as ready for review January 31, 2022 01:50
codecov.yml Outdated Show resolved Hide resolved
silkrpc/commands/engine_api.cpp Show resolved Hide resolved
silkrpc/ethbackend/backend_interface.hpp Outdated Show resolved Hide resolved
silkrpc/ethbackend/backend.hpp Outdated Show resolved Hide resolved
silkrpc/ethbackend/backend_mock.hpp Outdated Show resolved Hide resolved
tests/integration/run_jsonrpc_commands.py Outdated Show resolved Hide resolved
Copy link
Member

@canepat canepat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test module for BackEndGrpc should be named backend_grpc_test.cpp instead of backend_test.cpp for consistency

silkrpc/ethbackend/backend.hpp Outdated Show resolved Hide resolved
@canepat canepat merged commit dad0faf into master Feb 12, 2022
@canepat canepat deleted the get-payload-v1 branch February 12, 2022 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants