Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrequest.cpp: fix build with musl libc #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrea-adami
Copy link

fix following error:

| ../../git/src/webrequest.cpp:15:10: fatal error: sys/unistd.h:
No such file or directory
| 15 | #include <sys/unistd.h>

Signed-off-by: Andrea Adami [email protected]

fix following error:

 | ../../git/src/webrequest.cpp:15:10: fatal error: sys/unistd.h:
 No such file or directory
 |    15 | #include <sys/unistd.h>

Signed-off-by: Andrea Adami <[email protected]>
@eriksl
Copy link
Owner

eriksl commented Jun 20, 2021

Why doesn't musl have this header file?

It may very well be that the code needs declarations from this file.

@persianpros
Copy link

@eriksl

Would you please accept this and revert OpenPLi/openpli-oe-core@76b525c ?

@andrea-adami
Copy link
Author

andrea-adami commented Jun 20, 2021

Hi,
musl libc just doesn't have it.
If you check under /usr/include/sys, glibc sys/unistd.g is including unistd.h.

In fact it should be sufficient to include the latter, valid for both libc's.
Cheers
A.A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants