fprof: Fix crash when using pause/restart/continue when profiling all #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
added
team:VM
CT Test Results 2 files 22 suites 6m 11s ⏱️ Results for commit 59606f7. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/tools/tprof-fix-pause-restart-continue-server
branch
from
7d6e344
to
65ef84c
Compare
When running in server mode and profiling all, the function pause/restart/continue would crash as they received the atom 'all' as an interator. closes erlang#8472
garazdawi
force-pushed
the
lukas/tools/tprof-fix-pause-restart-continue-server
branch
from
65ef84c
to
59606f7
Compare
max-au
approved these changes
Jun 4, 2024
garazdawi
deleted the
lukas/tools/tprof-fix-pause-restart-continue-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in server mode and profiling all, the function pause/restart/continue would crash as they received the atom 'all' as an interator.
closes #8472