Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid link in edoc notes and Markdown #8584

Merged

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Jun 15, 2024

This PR fixes the below warning during doc generation:

warning: documentation references "e:system/documentation.md" but it is invalid
└─ notes.md: (file)

This also includes some Markdown and indentation issues as well.

Copy link
Contributor

github-actions bot commented Jun 15, 2024

CT Test Results

  2 files   13 suites   4m 15s ⏱️
145 tests 139 ✅ 6 💤 0 ❌
161 runs  155 ✅ 6 💤 0 ❌

Results for commit dd865cb.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kianmeng kianmeng force-pushed the fix-missing-and-incorrect-link-in-edoc-notes branch from 98e2595 to 0bb08fc Compare June 15, 2024 16:28
This PR fixes the below warning during doc generation:

warning: documentation references "e:system/documentation.md" but it is invalid                                                           └─ notes.md: (file)

This also includes some Markdown and indentation issues as well.
@kianmeng kianmeng force-pushed the fix-missing-and-incorrect-link-in-edoc-notes branch from 0bb08fc to dd865cb Compare June 15, 2024 16:29
@garazdawi
Copy link
Contributor

Hello! Thanks for the fixes! Would you mind targeting this towards maint instead so that we can get the fixes out faster?

@garazdawi garazdawi self-assigned this Jun 17, 2024
@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Jun 17, 2024
@kianmeng kianmeng changed the base branch from master to maint June 17, 2024 14:40
@garazdawi garazdawi merged commit 2614fcd into erlang:maint Jun 18, 2024
16 checks passed
@garazdawi
Copy link
Contributor

thanks!

@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants