Survive loading damaged or obsolete BEAM files #8623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the cleaning up of the off-heap list, don't crash when the pointer to a fun entry is NULL. That can happen if loading failed for some reason (the BEAM file was corrupted or too old).
Attempting to load an obsolete instruction with more than 6 operands could crash the runtime system.
When attempting to load obsolete instructions, the loading failed to recognize them and produced an unhelpful message instead of a polite request to recompile the module. This bug was introduced in 4dbc998.
bjorng
added
team:VM
CT Test Results 3 files 141 suites 49m 33s ⏱️ For more details on these failures, see this check. Results for commit 7ebe7f4. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime system could crash when attempting to load obsolete or damaged BEAM files (for example, loading code compiled by Erlang/OTP 23 in Erlang/OTP 27).