Fix dbg for remote nodes #8692
Merged
Fix dbg for remote nodes #8692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbg uses the new trace sessions and stores them in the main dbg server on the node that's doing the tracing. However, trace sessions are reference-counted NIF resources - this means that when the last reference is GC'ed on the node that owns the resource, the resouce is destroyed. In case of dbg, this meant that as soon as the first GC happened on the relay process, the session would be destroyed and tracing would silently stop. Furthermore, any subsequent requests to amend trace patterns, etc would fail for the remote nodes with badarg in trace module's functions. This fixes the issue by making the relay process hold onto the session reference for as long as the process is active. This solves the issue. The amended test fails before applying this change and succeeds after.
CT Test Results 2 files 19 suites 6m 2s ⏱️ Results for commit eb8a6bf. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
added
team:VM
|
Merged, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbg uses the new trace sessions and stores them in the main dbg server on the node that's doing the tracing. However, trace sessions are reference-counted NIF resources - this means that when the last reference is GC'ed on the node that owns the resource, the resouce is destroyed.
In case of dbg, this meant that as soon as the first GC happened on the relay process, the session would be destroyed and tracing would silently stop. Furthermore, any subsequent requests to amend trace patterns, etc would fail for the remote nodes with badarg in trace module's functions.
This fixes the issue by making the relay process hold onto the session reference for as long as the process is active. This solves the issue.
The amended test fails before applying this change and succeeds after.