kernel: Add possibility to disable prompt redrawing #8763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
added
team:VM
CT Test Results 3 files 143 suites 1h 31m 13s ⏱️ Results for commit 49ae08a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
removed
the
testing
frazze-jobb
reviewed
Sep 3, 2024
garazdawi
force-pushed
the
lukas/kernel/add-prompt-redraw-option/OTP-19213
branch
from
b2bf54d
to
5dc60f4
Compare
When stdout is used as both a terminal and as the main logging mechanism, redrawing the prompt will cause a lot of ANSI characters to be printed to the log when the prompt is redrawn. So we add this options for systems that have a hard time migrating away. It is only available in Erlang/OTP 26 as a temporary measure as in the long run no system should be using stdout as a logging mechanism and terminal at the same time.
garazdawi
force-pushed
the
lukas/kernel/add-prompt-redraw-option/OTP-19213
branch
from
5dc60f4
to
49ae08a
Compare
frazze-jobb
reviewed
Sep 4, 2024
| send_tty(Term2,"my_fun(5) -> ok; my_fun(N) -> timer:sleep(100), io:format(user, \"~p\\n\", [N]), my_fun(N+1).\n"), | ||
| send_tty(Term2,"spawn(shell_default, my_fun, [0]). ABC\n"), | ||
| timer:sleep(1000), | ||
| check_location(Term2, {0,-18}), %% Check that we are at the same location relative to the start. |
There was a problem hiding this comment.
Suggested change
| check_location(Term2, {0,-18}), %% Check that we are at the same location relative to the start. | |
| check_location(Term2, {0,-18}), %% Check that the prompt is not redrawn, cursor is at the beginning of the line |
| <p>Sets whether the shell should redraw the prompt when it receives output from other processes. | ||
| This setting can be useful if you use <c>run_erl</c> to for logging as redrawing the prompt will | ||
| emit a lot of ANSI escape characters that you normally do not want in a log. | ||
| The default is <c>true</c>.</p> |
There was a problem hiding this comment.
The documentation seems somewhat redundant if its only going to be supported in 26. But you should mention that its deprecated / removed in 27?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stdout is used as both a terminal and as the main logging mechanism, redrawing the prompt will cause a lot of ANSI characters to be printed to the log when the prompt is redrawn. So we add this options for systems that have a hard time migrating away. It is only available in Erlang/OTP 26 as a temporary measure as in the long run no system should be using stdout as a logging mechanism and terminal at the same time.
Supersedes #8644