Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kuba/ssh/no system sup for client/gh 7550 #8766

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Kuba/ssh/no system sup for client/gh 7550 #8766

merged 5 commits into from
Sep 23, 2024

Conversation

u3s
Copy link
Contributor

@u3s u3s commented Aug 30, 2024

No description provided.

@u3s u3s added the team:PS Assigned to OTP team PS label Aug 30, 2024
@u3s u3s self-assigned this Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

CT Test Results

    3 files    342 suites   23m 54s ⏱️
1 182 tests 1 178 ✅  4 💤 0 ❌
6 976 runs  6 952 ✅ 24 💤 0 ❌

Results for commit 5862f24.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s changed the base branch from maint to master August 30, 2024 16:51
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Aug 30, 2024
@u3s u3s requested a review from IngelaAndin September 2, 2024 08:00
@u3s u3s mentioned this pull request Sep 2, 2024
Closed
@u3s u3s added testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Sep 3, 2024
@u3s u3s force-pushed the kuba/ssh/no_system_sup_for_client/GH-7550 branch from 532436e to efd9481 Compare September 4, 2024 16:34
@u3s u3s linked an issue Sep 10, 2024 that may be closed by this pull request
Race conditions on startup of an ssh connection with the client role #7550
Closed
@u3s u3s mentioned this pull request Sep 10, 2024
Closed
IngelaAndin
IngelaAndin approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@IngelaAndin IngelaAndin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement of what we have, although I think there are more improvements to do I think we should merge this as first step in the right direction.

@u3s u3s changed the base branch from master to maint September 18, 2024 12:26
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Sep 18, 2024
@u3s u3s force-pushed the kuba/ssh/no_system_sup_for_client/GH-7550 branch from efd9481 to 5862f24 Compare September 19, 2024 09:48
@u3s u3s merged commit 0bf06d2 into erlang:maint Sep 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IngelaAndin IngelaAndin IngelaAndin approved these changes

Assignees

@u3s u3s

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race conditions on startup of an ssh connection with the client role
2 participants
@u3s @IngelaAndin