Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hardcoded variables configurable from content repo #71

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

JaroCamphuijsen
Copy link
Collaborator

@JaroCamphuijsen JaroCamphuijsen commented Aug 1, 2024

  • Github organization in the banner GH logo link
  • Github repository in the banner GH logo link
  • Organization logo in the banner (currently eScience Center)
  • Organization website in the banner (currently eScience Center)
  • reveal.js theme (currently the eScience theme)
  • footer organization name and link

fixes #70

@JaroCamphuijsen
Copy link
Collaborator Author

JaroCamphuijsen commented Nov 6, 2024

Content repositories should also change because of this PR. The following changes are needed:

  • Expand config.json with organization url
  • Add organization logo image to content repository
  • Expand config.json with logo image location

@JaroCamphuijsen JaroCamphuijsen marked this pull request as ready for review November 15, 2024 22:34
Copy link
Collaborator

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good work. These are useful things to be able to configure!

@raar1
Copy link
Collaborator

raar1 commented Nov 19, 2024

Also glad not to see "Let's Stay in Touch!" 400 times a day

@raar1
Copy link
Collaborator

raar1 commented Nov 19, 2024

Actually, be careful after merging to check that the equations render correctly (since this branch does not have that functionality yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard coded configuration variables
2 participants