Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #119

Merged
merged 10 commits into from
Jun 25, 2024
Merged

Minor fixes #119

merged 10 commits into from
Jun 25, 2024

Conversation

fnattino
Copy link
Collaborator

Had drafted this fixes before the workshop but did not make it to open the PR for them.

Mostly very minor things, some of which carried out by my IDE (e.g. trailing white spaces removed).

@fnattino fnattino requested a review from Morrizzzzz June 19, 2024 10:34
@fnattino fnattino marked this pull request as ready for review June 19, 2024 10:34
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
Copy link

github-actions bot commented Jun 19, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/geospatial-python/compare/md-outputs..md-outputs-PR-119

The following changes were observed in the rendered markdown documents:

 01-intro-raster-data.md                            |  63 +--
 02-intro-vector-data.md                            |  30 +-
 03-crs.md                                          |  20 +-
 04-geo-landscape.md                                |  24 +-
 05-access-data.md                                  | 299 +++++++----
 06-raster-intro.md                                 | 572 +++++++++++++++------
 07-vector-data-in-python.md                        | 482 ++++++++---------
 08-crop-raster-data.md                             | 266 ++++------
 09-raster-calculations.md                          | 323 +++++-------
 10-zonal-statistics.md                             | 166 +++---
 11-parallel-raster-computations.md                 | 199 +++----
 fig/E05/STAC-s2-preview-after.jpg (new)            | Bin 0 -> 70832 bytes
 fig/E05/STAC-s2-preview-before.jpg (new)           | Bin 0 -> 75077 bytes
 fig/E06/rhodes_multiband_80.png (new)              | Bin 0 -> 1033117 bytes
 fig/E06/rhodes_multiband_80_equal_aspect.png (new) | Bin 0 -> 861267 bytes
 fig/E06/rhodes_red_80_B04.png (new)                | Bin 0 -> 590536 bytes
 fig/E06/rhodes_red_80_B04_robust.png (new)         | Bin 0 -> 946323 bytes
 fig/E06/rhodes_red_80_B04_robust_nan.png (new)     | Bin 0 -> 865948 bytes
 .../rhodes_red_80_B04_vmin100_vmax2000.png (new)   | Bin 0 -> 880764 bytes
 fig/E06/rhodes_red_B04.png (new)                   | Bin 0 -> 801039 bytes
 fig/E07/greece_administration_areas.png (new)      | Bin 0 -> 64055 bytes
 fig/E07/greece_highways.png (new)                  | Bin 0 -> 26479 bytes
 fig/E07/rhodes_administration_areas.png (new)      | Bin 0 -> 17351 bytes
 fig/E07/rhodes_assets.png (new)                    | Bin 0 -> 45400 bytes
 fig/E07/rhodes_builtup_buffer.png (new)            | Bin 0 -> 18396 bytes
 fig/E07/rhodes_highways.png (new)                  | Bin 0 -> 80495 bytes
 fig/E07/rhodes_infra_highways.png (new)            | Bin 0 -> 46913 bytes
 fig/E08/dem.png (new)                              | Bin 0 -> 98203 bytes
 fig/E08/dem_matched.png (new)                      | Bin 0 -> 122237 bytes
 fig/E08/visual_clip.png (new)                      | Bin 0 -> 77146 bytes
 fig/E08/visual_clip_box.png (new)                  | Bin 0 -> 374262 bytes
 fig/E08/visual_large.png (new)                     | Bin 0 -> 197716 bytes
 fig/E09/NDVI-hist.png                              | Bin 7916 -> 14496 bytes
 fig/E09/NDVI-map.png                               | Bin 163222 -> 332276 bytes
 fig/E09/NDWI.png (new)                             | Bin 0 -> 314396 bytes
 fig/E09/NIR-band.png                               | Bin 167850 -> 276002 bytes
 fig/E09/custom-index.png (new)                     | Bin 0 -> 429445 bytes
 fig/E09/red-band.png                               | Bin 162461 -> 265509 bytes
 fig/E09/visual-burned-index.png (new)              | Bin 0 -> 357171 bytes
 fig/E10/zones_rasterized_xarray.png (new)          | Bin 0 -> 31334 bytes
 fig/E11/dask-graph.png                             | Bin 2311171 -> 94585 bytes
 index.md                                           |  44 +-
 md5sum.txt                                         |  26 +-
 setup.md                                           |  27 +-
 44 files changed, 1315 insertions(+), 1226 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-19 13:32:53 +0000

@fnattino fnattino changed the title Minor fixes to EP5 and index Minor fixes Jun 19, 2024
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
Copy link

@Morrizzzzz Morrizzzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I had one tiny thing

episodes/06-raster-intro.md Show resolved Hide resolved
episodes/05-access-data.md Outdated Show resolved Hide resolved
@fnattino fnattino merged commit 9160858 into draft_30042024 Jun 25, 2024
1 of 2 checks passed
@fnattino fnattino deleted the minor-fixes-ep5 branch June 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants